search

ebitengine / purego

Apache License 2.0
2.16k stars 68 forks source link

internal/fakecgo: match Go's implementation #142

Closed TotallyGamerJet closed 1 year ago

TotallyGamerJet commented 1 year ago

This code inlined the macros to avoid copying the header. However, the header was copied into the project for other reasons and this code never got updated to match the Go implementation.

hajimehoshi commented 1 year ago

However, the header was copied into the project for other reasons and this code never got updated to match the Go implementation.

And this change fixes the situation by using the existing macro so that this code would get updated, right?

TotallyGamerJet commented 1 year ago

And this change fixes the situation by using the existing macro so that this code would get updated, right?

Correct. Any changes to abi_amd64.h can easily be copied into our version so no changes to asm_amd64.s need to happen to keep in sync with Go's version.