search

ebitengine / purego

Apache License 2.0
1.95k stars 63 forks source link

move C tests into testdata/ #203

Closed TotallyGamerJet closed 5 months ago

TotallyGamerJet commented 5 months ago

These don't have public API so move them into internal to cleanup root folder

hajimehoshi commented 5 months ago

Though I suggested using internal in the Discord server a PR comment, I realized that testdata directory sounds better.

https://pkg.go.dev/cmd/go#hdr-Test_packages

The go tool will ignore a directory named "testdata", making it available to hold ancillary data needed by the tests.

Assuming libcbtest, libdlnested, and structtest are not Go packages, what about moving them into testdata instead of internal? Or, if there is a possibility that they become Go packages that have to be built by a Go tool like go build ./..., internal is better. What do you think?

TotallyGamerJet commented 5 months ago

There is no intention of them being go packages. Moving them into testdata is a great idea