search

ebitengine / purego

Apache License 2.0
1.94k stars 63 forks source link

Add RegisterFunc on unsupported platforms #234

Closed TotallyGamerJet closed 2 months ago

TotallyGamerJet commented 2 months ago

Closes #230

TotallyGamerJet commented 2 months ago

Current outstanding issues:

  1. Windows 386 qsort test fails. I don't have a Windows computer to investigate so I just disabled it.
  2. Add more "unsupported" platforms to the GitHub workflows.
hajimehoshi commented 2 months ago

Hmm, let's fix the issue with 386 and RegisterFunc first, and then address on #230.

TotallyGamerJet commented 2 months ago

Well it is now confirmed it is something wrong in RegisterFunc as just directly calling SyscallN worked just fine

I had forgotten to enable the test again. It now fails. This deserves a deeper investigation now.

TotallyGamerJet commented 2 months ago

We should probably run the CI on other architectures as well.

hajimehoshi commented 2 months ago

We should probably run the CI on other architectures as well.

Which architectures? Like, Linux 386?

TotallyGamerJet commented 2 months ago

@hajimehoshi this is ready for review