ec-doris / kohesio-frontend

Web interface for Kohesio project
https://kohesio.ec.europa.eu
8 stars 0 forks source link

Reframing EU North #330

Closed madewild closed 2 years ago

madewild commented 2 years ago

Can we slightly change the default coordinates of the map (max latitude) so that Sweden and Finland are shown in full when first loading the page? Currently they are slighly cut in the North: se-fi

Request of REGIO map unit...

madewild commented 2 years ago

or maybe this is coming from the backend @D063520 ?

D063520 commented 2 years ago

no, it is not coming form the backend .... it is hard coded in the ui

raphdom commented 2 years ago

yes, I will change it

raphdom commented 2 years ago

done, can you check please?

madewild commented 2 years ago

For me it still appears slightly cut :/ cut

raphdom commented 2 years ago

it is, but if I put more we will cut in the south

madewild commented 2 years ago

mmmh annoying, and we cannot zoom out very slightly (without making it very small)?

madewild commented 2 years ago

Full comment of REGIO: "The entry view of the map shows a very wide frame covering areas that are not relevant for the EU (Greenland, Kyrgyzstan…) while the northern part of the EU is missing. Our suggestion is to use a frame that is less wide and that ensures that the whole north/south extent of continental Europe is visible (i.e. from northern SE + FI to CY, Ceuta and Melilla).

Maybe we can change the height of the map?

raphdom commented 2 years ago

no, because the zoom has levels. Another solution could be increase the height of the map. But the right size will be 725px it is too big for small screens:

Screenshot 2022-02-03 at 08 56 36
raphdom commented 2 years ago

https://www.browserstack.com/guide/ideal-screen-sizes-for-responsive-design#:~:text=According%20to%20the%20Worldwide%20Screen,360%C3%97640%20(7.28%25)

I think it will be fine to go to 725px. What do you think?

madewild commented 2 years ago

ok let's test!

raphdom commented 2 years ago

done, you can test

madewild commented 2 years ago

Much better! Maybe we can save some space between the carousel and "in my region" to compensate? (orange zone) orange2

raphdom commented 2 years ago

I will tell @omar0z to change the margin in home component (change class mt-5 to mt-2), to avoid to touch in the same file... then you can close this @madewild