search

ec-doris / kohesio-frontend

Web interface for Kohesio project
https://kohesio.ec.europa.eu
8 stars 0 forks source link

Add all CCIs button produces null CCIs in invitation payload #937

Open svili opened 2 months ago

svili commented 2 months ago

On Acceptance, to reproduce: On the "Add user" dialog:

  1. Choose invitation
  2. Role EDITOR or REVIEWER
  3. Choose any country (tested with Cyprus, Finland and Croatia)
  4. Add all CCIs button
  5. Send

Return 400 error from BFF probably due to the payload having a list of nulls in the allowed_cci_qids list.

madewild commented 2 months ago

Indeed, on https://github.com/ec-doris/kohesio-frontend/issues/916 I wrote "the button could be hidden when no country is selected"

svili commented 2 months ago

Ah sorry, edited the issue, this happens when country is selected.

madewild commented 2 months ago

Ah sorry I see it's greyed out on ACC... @svili did you select a country first?

madewild commented 2 months ago

(forget about my previous comments @ntorbev ;) )

madewild commented 2 months ago

@svili I just tested on ACC with Cyprus and I can see the correct list of CCIs added below the button...

svili commented 2 months ago

Yes, the UI shows it correctly but hitting SAVE is an error because the payload produced contains nulls. image

ntorbev commented 2 months ago

Hi @madewild it should be fine now

raphdom commented 2 months ago

You can test in test, if everything is good, I am going to do a bugfix on PROD

madewild commented 2 months ago

@svili can you please test since you found the bug in the first place?