BIRT-designer/Nightly Build 4.16.0-202405152028, Report invisible & error on opening of reports - GraphicalEditorWithFlyoutPalette.getGraphicalViewer() throws NPE

[speckyspooky]

I have tested our nightly build of BIRT 4.16 and got a NullPointerException at the first moment if a report will be displayed.

This means if you open a report, result: NullPointerException and the report cannot be displayed If you start the designer with an existing report from session before, result: NullPointerException and the report cannot be displayed

I used the Windows version of our nightly build and tried to show an exiting report. Then I got the error message of GraphicalEditorWithFlyoutPalette.getGraphicalViewer():

java.lang.NullPointerException: Cannot invoke "org.eclipse.gef.GraphicalViewer.getProperty(String)" because the return value of "org.eclipse.birt.report.designer.internal.ui.editors.parts.GraphicalEditorWithFlyoutPalette.getGraphicalViewer()" is null

Full stacktrace: birt-4.16-latest-build-202405152028.txt

[speckyspooky]

@merks Hi Ed, could you please be so kind and test it from your side as a double check on it. The report will be already displayed if I go to the master-layout. This will be displayed and afterwards go back to the report-layout.

But with the restart of eclipse or if I open the report, I get the error again.

I tested different version of BIRT 4.16 with the following results:

» N202405152028, ERROR with NPE » N202405131950, ERROR with NPE » N202405121352, ERROR with NPE » N202405091756, OK

Could it be that we have a side effect through XYLayout-change #1678 ...?

[merks]

With a debug launch it launched okay for me:

I see the viewer being created and set here:

Are you able to reproduce it in the debugger?

Be sure to update the target platform so you have the latest GEF and stuff:

I notice your project explorer is empty. Mine is not:

Are you opening the editor with "strange" editor inputs rather than from resources in the workspace?

[speckyspooky]

Hello Ed, I doesn't used my local dev-environment. I downloaded our all-in-one-designer and used the nightly build https://download.eclipse.org/birt/updates/nightly/latest/index.html

In my screen you see the empty "Palette" from the designer and the report is used from a discussion today #1688 The report isn't complex it is a table report with a dynamic table.

[merks]

How exactly did you open it? Why is the workspace empty? See picture that for me the reports are in the workspace in a project.

[speckyspooky]

I started the designer and opened directly a report. The report isn't located at the workspace, it was located under the download-folder.

Opening of the report

Result after loading

[merks]

Using File -> Open? I can't reproduce it that way either, from a debug launch. I suggest trying to repeat the process in a debug launched workspace; unless we can reproduce it in the debugger, we're going to find it next to impossible to fix the problem. (I don't really have time this evening.)

[speckyspooky]

No problem, the topic is on my side the same I can not reproduce the issue on my local side. There all is fine. I don't know why the nightly build has this issue...?

[merks]

I see. In the worst case I can try to remote debug it and hope that sheds light.

[speckyspooky]

I have retested the nightly build from this night "N202405162016" and the retest of the all-in-one-designer looks very good.

The NPE are not longer listed. My PR from last evening has nothing to do with this topic. Therefore I would say there was a topic with our build internally or some changes was done from the eclipse-framework side to solve such topics.

[merks]

Very strange. So I guess we can close this?

[speckyspooky]

Of course, we can close it.

[merks]

Given nightly builds of GEF are being used, it's possible that some intermediate GEF build had a bug that was then fixed by a subsequent build. All is well that ends well. 😄