eclipse-csi / otterdog

OtterDog is a tool to manage GitHub organizations at scale using a configuration as code approach. It is actively used by the Eclipse Foundation to manage its numerous projects hosted on GitHub.
https://otterdog.readthedocs.org
Eclipse Public License 2.0
20 stars 2 forks source link

Scope commands #211

Closed mbarbero closed 3 months ago

mbarbero commented 4 months ago

Currently, the commands for Otterdog, such as verify, merge, etc., are not scoped. They can be placed anywhere within the comment body as long as they start with a /. This approach could potentially lead to confusion, unintended consequences, or even conflicts with other applications.

This ticket aims to discuss the adoption of scoped commands, similar to how Dependabot operates (https://docs.github.com/en/code-security/dependabot/working-with-dependabot/managing-pull-requests-for-dependency-updates#managing-dependabot-pull-requests-with-comment-commands), for example:

@otterdog verify
@otterdog merge
@otterdog help

Thoughts?

netomi commented 4 months ago

Sounds reasonable. I was already thinking of applying something similar as dependabot.

netomi commented 3 months ago

Using @otterdog is not a good idea, as it will tag the user otterdog, which exists:

https://github.com/otterdog

netomi commented 3 months ago

Some other prefixes that might work:

my preference would be ., so the commands would look like .otterdog validate, or just keep using / with scope, e.g. /otterdog validate

mbarbero commented 3 months ago

Good catch about @otterdog. I tend to prefer the / prefix (with scope, ie /otterdog) as it's closer to other "command language", like in IRC, Slack, or Discord.

mbarbero commented 3 months ago

👍