Update Neo4J engine to use Java instead of Groovy - Githubissues

eclipse / jnosql

Eclipse JNoSQL is a framework which has the goal to help Java developers to create Jakarta EE applications with NoSQL.

Other

229 stars 72 forks source link

Update Neo4J engine to use Java instead of Groovy #334

Closed otaviojava closed 1 year ago

otaviojava commented 1 year ago

Fix: https://github.com/eclipse/jnosql/issues/333

Changes

Update Apache Tinkerpop to version 3.6.2
Fix the issue on the query parameter with @ . E.g. g.V().hasLabel(@label
Remove the Grovy-gremlin parser
Use Java Parser at Gremlin

:warning: I found a new issue on the Neo4J start-up. But I would like to fix another PR. :bomb: We still need to fix this https://github.com/eclipse/jnosql/issues/335 to complete solution of Java 17 issue.

otaviojava commented 1 year ago

@dearrudam what do you think? Could you review it?

otaviojava commented 1 year ago

@dearrudam the directory is because the Graph-module needs to recompile the ANLTRs to the Apache Tinkerpop version. Until they update their project is an option that we have.

otaviojava commented 1 year ago

@dearrudam to where? lol

dearrudam commented 1 year ago

@otaviojava LOL! I've just edited that comment again!

otaviojava commented 1 year ago

@dearrudam I don't follow you on this point:

Also, I think if we follow the default approach, we'll be able to eliminate some custom configurations in /jnosql-communication/jnosql-communication-query/pom.xml as below:

What do you mean? Please, put the plugin as you wish or open a PR to my branch.

dearrudam commented 1 year ago

@otaviojava I've just opened this PR: #336 to your branch.

otaviojava commented 1 year ago

Thank you @dearrudam

otaviojava commented 1 year ago

I'll include a CI with Java 17 to ensure it keeps working.