search

eclipse / jnosql

Eclipse JNoSQL is a framework which has the goal to help Java developers to create Jakarta EE applications with NoSQL.
Other
231 stars 72 forks source link

Include build and test execution for PRs #372

Open eliasnogueira opened 1 year ago

eliasnogueira commented 1 year ago

Which JNoSQL project the issue refers to?

JNoSQL (Core)

Use case

Context

We expect people to contribute to the JNOSQL project. When they submit a PR, we expect that all the tests are run, even in the not touched modules to guarantee the project's reliability.

Currently, there's no test running when a PR is open.

Feature proposal

The proposal is to include the build and test process when a contributor opens a PR, even if it will run again during the merge process.

This will prevent a possible long feedback loop to fix possible issues.

otaviojava commented 1 year ago

Hey @eliasnogueira Check your latest PR: https://github.com/eclipse/jnosql/pull/369

We're running both Java 17 and 20. Once it is on Eclipse Foundation availability nodes, it takes some time to start to run.

Screenshot from 2023-04-24 16-26-05

eliasnogueira commented 1 year ago

@otaviojava maybe we can do this targeting only one Java version in the PR process. Another possible solution would tag the necessary tests/modules to run the tests.