search

eclipse / jnosql

Eclipse JNoSQL is a framework which has the goal to help Java developers to create Jakarta EE applications with NoSQL.
Other
231 stars 72 forks source link

refact: assertNotNull with primitive #406

Closed artsmandev closed 1 year ago

artsmandev commented 1 year ago

My change suggestions are about refact:

  1. Removing the AssertNotNull with hashCode(), because hashCode() is primitive.
  2. It was missing a H in shoudReturnHashCode:
    1. I had the idea to suggest shouldReturnSameHashCode
  3. personRepository.equals(personRepository), returns false, i had the idea to suggest:
    1. Rename de method to: shouldReturnNotNull
    2. Use only one argument
  4. Removed an import that was lost.

Thank you.

genie-jnosql commented 1 year ago

Can one of the admins verify this patch?