Fixes issue #407: Fixes Reflections.getConstructor() method logic to detect constructors with parameters annotated with @Id or @Column

eclipse / jnosql

Eclipse JNoSQL is a framework which has the goal to help Java developers to create Jakarta EE applications with NoSQL.

Other

229 stars 72 forks source link

Fixes issue #407: Fixes Reflections.getConstructor() method logic to detect constructors with parameters annotated with @Id or @Column #409

Closed dearrudam closed 1 year ago

dearrudam commented 1 year ago

Fixes: https://github.com/eclipse/jnosql/issues/407

Changes

Fixes Reflections.getConstructor() method logic to detect constructors with parameters annotated with @Id or @Column

genie-jnosql commented 1 year ago

Can one of the admins verify this patch?

otaviojava commented 1 year ago

@dearrudam did you find one way to reproduce it with unit tests?

dearrudam commented 1 year ago

@dearrudam did you find one way to reproduce it with unit tests?

No, @otaviojava. I don't know how to reproduce it on our side... as this issue was detected in Quarkus integration by now, my suspicion is that it's related to something that Quarkus is doing under the hood maybe... but, I think that this PR fixes this issue without problems according to the test suite implemented on the project (in special this test) and by considering the evidence that I described on this comment also.

otaviojava commented 1 year ago

Merged, thank you @dearrudam