search

eclipse / microprofile-conference

Microprofile.io Demo Code - Web Services Conference Application
http://microprofile.io/
Apache License 2.0
117 stars 116 forks source link

Issue160-DemConfigAPI #161

Closed susanodom closed 6 years ago

susanodom commented 7 years ago

pull request for issue 160

aguibert commented 6 years ago

@Emily-Jiang did you have any thoughts on this PR? It looks like a good initial demonstration of MP Config in the Vote service.

heiko-braun commented 6 years ago

For those who don't run on cloud foundry this seems a bit too specific (VCAP_*). I like the idea of using mp-config with the services, but would prefer a vendor or target environment neutral setup.

Emily-Jiang commented 6 years ago

@aguibert the changes are fine but the pom dependency should be against mpConfig-1.1. @heiko-braun Since vote service was written to be deployed to cloud foundry, it makes sense to use vcap. By the way, if VCAP does not exist, it will fall back to cloudant connection. This PR did not introduce VCAP but just try to inject the config.

aguibert commented 6 years ago

This PR can be closed, as it has already been merged under PR #172

Emily-Jiang commented 6 years ago

close as per the comments from @aguibert