search

eclipse / microprofile-conference

Microprofile.io Demo Code - Web Services Conference Application
http://microprofile.io/
Apache License 2.0
117 stars 116 forks source link

Added the KumuluzEE implementation for the schedule microservice #169

Open TFaga opened 6 years ago

OndroMih commented 6 years ago

I tried to build with mvn install -DskipTests and I got an exception when the app was started:

[ERROR] java.lang.NoClassDefFoundError: org/objectweb/asm/ClassVisitor
[ERROR]     a  t  org.eclipse.je tty.annotations.AnnotationConfiguration.createAnnotationParser(AnnotationConfiguration.java:506)
[ERROR]     a  t  org.eclipse.je tty.annotations.AnnotationConfiguration.scanForAnnotations(AnnotationConfiguration.java:421)
[ERROR]     a  t  org.eclipse.je tty.annotations.AnnotationConfiguration.configure(AnnotationConfiguration.java:363)

When I then executed the JAR from command line it was OK. So I think it's enough if the build doesn't start the app, only builds the JAR.

TFaga commented 6 years ago

I see. I've put the tests to run as part of the integration-test phase, I'll try and move them to the test phase or make sure to disable them if the option is passed, so they can be skipped when installing.

OndroMih commented 6 years ago

@TFaga, have you signed the Eclipse Contributor Agreement? If yes, did you use tilen.faganel@me.com with Eclipse? Otherwise, please see https://www.eclipse.org/legal/ECA.php to sign the agreement, so that we may accept your PRs.

TFaga commented 6 years ago

I've added the tests to a profile that is disabled when -DskipTests is used. Just signed the agreement, should be OK now.

TFaga commented 6 years ago

We have added KumuluzEE implementations of the Schedule and the Speaker microservices. Both services have Health (/health endpoint), Metrics (/metrics) and Config included and implemented. For Metrics, there is also a Prometheus exporter accessible on /prometheus (which is a nice addition for the demo).

pilhuhn commented 6 years ago

On 30 Sep 2017, at 4:23, Tilen Faganel wrote:

We have added KumuluzEE implementations of the Schedule and the Speaker microservices. Both services have Health (/health endpoint), Metrics (/metrics) and Config included and implemented. For Metrics, there is also a Prometheus exporter accessible on /prometheus (which is a nice addition for the demo).

The MP-Metrics /metrics should respond with Prometheus text data if nothing else is requested, so how is /prometheus different here?

TFaga commented 6 years ago

We have mapped the Prometheus to /prometheus endpoint and JSON output to /metrics endpoint, in order to better demonstrate both of the formats.