search

eclipse / microprofile-conference

Microprofile.io Demo Code - Web Services Conference Application
http://microprofile.io/
Apache License 2.0
117 stars 116 forks source link

Remove duplicated line #187

Closed brunoborges closed 6 years ago

cesarhernandezgt commented 6 years ago

@brunoborges , in order to pass the ip-validation, you just need to append to your commit message something like: Signed-off-by: YourGitHubUsername <YourEmailUsedForThisGitRepo>

brunoborges commented 6 years ago

Signed-off-by: brunoborges bruno.borges@gmail.com

brunoborges commented 6 years ago

Signed-off-by: brunoborges bruno.borges@microsoft.com

cesarhernandezgt commented 6 years ago

Hi, @brunoborges . I think the signed-off line needs to go as part of your git commit message, not on the PR message.

mikecroft commented 6 years ago

The easiest way is to make sure the problem commit is the most recent one, then run this command:

git commit --amend -s

It will reopen the previous commit message and automatically add your name/email in the correct format. Then you can just save and push your commit again.

brunoborges commented 6 years ago

Will reopen.