search

eclipse / microprofile-conference

Microprofile.io Demo Code - Web Services Conference Application
http://microprofile.io/
Apache License 2.0
117 stars 116 forks source link

Update microprofile-session to Thorntail #196

Closed xstefank closed 4 years ago

xstefank commented 4 years ago

I have a student which will be transforming this project (microprofile-session) to the Quarkus runtime. However, the original WildFly swarm based service no longer compiles so I moved it to Thorntail (updated WildFly swarm) so the student can work with it.

kenfinnigan commented 4 years ago

Looks like TravisCI build is broken

xstefank commented 4 years ago

However, a strange error - https://travis-ci.com/github/eclipse/microprofile-conference/builds/157285620. We are still based on JDK 8 so why should Travis expect 9 to 15? :)

However, the build will still fail on other modules being outdated, unfortunately. I will try to find some time to update those also. I would like to merge this as is now. Locally passing with JDK 8.

xstefank commented 4 years ago

I tried to get approval from different participants but unsuccessfully yet. I will merge this because the student needs to start working on it. If there is any issue found later I will submit a new PR. Sorry for any inconvenience.

Emily-Jiang commented 4 years ago

@xstefank just an ack to say that your changes are good.

xstefank commented 4 years ago

thanks @Emily-Jiang :)