search

edgi-govdata-archiving / EEW_SDWA_NJ

An open educational resource developed at the Environmental Data and Governance Initiative for interactive exploration of New Jersey's waters and water pollution.
https://eew-sdwa-nj.streamlit.app/
GNU General Public License v3.0
1 stars 0 forks source link

load default variables + flow reorganization #100

Closed ericnost closed 1 year ago

ericnost commented 1 year ago

fixes #99 fixes #89 fixes #68

ericnost commented 1 year ago

integrates new "slippy" flow control, and #105 as of 7/27 fixes #106 fixes #96 (!) fixes #92 fixes #84 (mostly; see https://github.com/randyzwitch/streamlit-folium/issues/121) fixes #70 fixes #65 addresses #63 (using marker clusters, but we still need a context note.)

ericnost commented 1 year ago

@Frijol I took your #105 context branch and merged it in with these functionality changes - adding the slippy selection, fixing some maps, and reorganizing the flow.

There are still some lingering issues:

  1. styling on the slippy selection page (but that's a bug in folium)
  2. the slippy selection page always reverts back to the default Paterson area after visiting other pages. I know why this is but it may not be fixable based on the other functionality we're looking for. It's not the worst thing in the world.
  3. I haven't addressed these points on the slippy selection, but will try at some point hopefully:

    Make a closer zoom correspond to selecting a tighter area (possibly it already does?) Give a bit of buffer so users can see (at least most of) the shapes included in the selection

But I am about maxed out on this. I think we're in a good spot to really polish up the text/context now.