search

edgi-govdata-archiving / EEW_SDWA_NJ

An open educational resource developed at the Environmental Data and Governance Initiative for interactive exploration of New Jersey's waters and water pollution.
https://eew-sdwa-nj.streamlit.app/
GNU General Public License v3.0
1 stars 0 forks source link

Show facility violations in on EJ maps #88

Closed Frijol closed 1 year ago

Frijol commented 1 year ago

The EJ page promises "How do SDWA Violations relate to Environmental Justice (EJ) in the Selected Area?" but we don't actually show SDWA violations. Can we do that? I'm thinking we might overlay the points from the SDWA violations page onto the EJ maps.

ericnost commented 1 year ago

~Circle size = # of violations, I think it should be showing? I think this is done? Will check after the server is back up.~

ericnost commented 1 year ago

I think the issue is that if you don't draw an area, it won't pull up markers to show on this page. In other words, navigating directly to the EJ page means no markers. Ultimately that's because of very small technical change I made, and is fixable, but it illustrates the challenges of accounting for all possible pathways through the site.

Frijol commented 1 year ago

oh! I didn't know I was hitting a bug, thought we just didn't have this feature

ericnost commented 1 year ago

Hmm I may have exaggerated when I said "it's fixable" lol. Basically, we can't show facility violations on the EJ maps unless the user goes to the Violations page first. But we could show other markers?

Frijol commented 1 year ago

Hm. I'm not too concerned about this one. But do we know that we don't have them? Would be nice (not necessary) to show a note that you can go get them by going to Violations and then coming back

ericnost commented 1 year ago

Yes, we have them, just not on this page unless they've visited Violations. So a note about going back to Violations and then coming back would make sense.