search

edmundsj / rcwa

Rigorous Coupled Wave Analysis for the calculation of Photonic Crystal R/T spectra
MIT License
97 stars 30 forks source link

1d grating tests #48

Closed rc14193 closed 2 years ago

rc14193 commented 2 years ago

Implemented tests for K matrices, VWX, and Scatter

edmundsj commented 2 years ago

I updated the Build workflow so it should now run on a pull request as well, but I ran these tests locally and they are all passing. Looks good to me! Excellent work. Approving PR.