edmundsj / rcwa

Rigorous Coupled Wave Analysis for the calculation of Photonic Crystal R/T spectra
MIT License
100 stars 31 forks source link

WIP Attempting to fix build pipeline Issue #57 #58

Closed edmundsj closed 1 year ago

edmundsj commented 1 year ago

Switched the progressbar2 library back to progressbar, switched to using pipenv from conda in anticipation of making the build system more modular and re-creating build issues locally. WIP.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 :warning:

Comparison is base (ed593a7) 97.13% compared to head (e6c954d) 97.06%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ========================================== - Coverage 97.13% 97.06% -0.07% ========================================== Files 17 17 Lines 1501 1501 ========================================== - Hits 1458 1457 -1 - Misses 43 44 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.06% <100.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Edmunds#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/edmundsj/rcwa/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Edmunds) | Coverage Δ | | |---|---|---| | [rcwa/solver.py](https://app.codecov.io/gh/edmundsj/rcwa/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Edmunds#diff-cmN3YS9zb2x2ZXIucHk=) | `95.90% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/edmundsj/rcwa/pull/58/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Edmunds)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.