search

eduNEXT / tutor-contrib-edunext-distro

A tool to facilitate the customization of an Openedx instance, adding commands and settings to have an easy-to-use and a ready-to-deploy in local or in development openedx distribution.
2 stars 1 forks source link

[FEAT] use faster config for theming config at eox-tenant #23

Closed felipemontoya closed 1 year ago

felipemontoya commented 1 year ago

Is your feature request related to a problem? Please describe. Pulling the information of the theming options is currently a bit slow.

Describe the solution you'd like I'd like that we skip some of the sources, We need to set this values at the root of the lms.envs.json.

"EOX_THEMING_CONFIG_SOURCES":[
  "from_eox_tenant_microsite_v0",
  "from_django_settings"
],

We should move to a place wehre we can use only from_django_settings. That is however not possible yet, since we actually need the compatibility from from_eox_tenant_microsite_v0 due to the way we manage settings for the sites in control center.

Describe alternatives you've considered

Make a change in eox_theming where I add a block such as:

    settings.EOX_THEMING_CONFIG_SOURCES = getattr(settings, 'ENV_TOKENS', {}).get(
        'EOX_THEMING_CONFIG_SOURCES',
        settings.EOX_THEMING_CONFIG_SOURCES
    )

It turns out this was not necessary.

felipemontoya commented 1 year ago

Now we have https://github.com/eduNEXT/eox-theming/pull/37. Once merged, this issue requires the configuration of:

"EOX_THEMING_CONFIG_SOURCES":[
  "from_eox_tenant_microsite_v2",
  "from_django_settings"
],