search

eduNEXT / tutor-contrib-edunext-distro

A tool to facilitate the customization of an Openedx instance, adding commands and settings to have an easy-to-use and a ready-to-deploy in local or in development openedx distribution.
2 stars 1 forks source link

[BUG] CSV files cannot be uploaded when using s3 as a storage engine #29

Closed DonatoBD closed 1 year ago

DonatoBD commented 1 year ago

Describe the bug

When we use s3 as a storage engine and try to upload a CSV file, an error occurs where it won't let us upload it to s3. This error was identified using the Staff Graded Points component when uploading a CSV file to modify the grades of the students in the course.

After some research, it seems that since maple release, this problem occurs and the solution was done in this PR

Since the openedx versions do not have this change yet, it would be necessary to update the super-csv package on our side while openedx is updating these requirements

To Reproduce Steps to reproduce the behavior:

  1. Install the minio plugin to be able to simulate locally the connection to s3
  2. Create a course
  3. Go to Studio > Settings > Advanced settings
  4. Add "edx_sga" to the Advanced Module List
  5. Go to the course outline, create a unit
  6. Add Staff graded points component (Add new component > Problem > Advanced > Staff Graded Points)
  7. Publish your unit and check the preview
  8. Click on the Export button, open the file, put 1 on the New Points column and click on Import Scores to upload the new file

Expected behavior The csv is processed correctly and a message is displayed saying that the scores were modified

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

santiagosuarezedunext commented 1 year ago

Hi Donato, I am going to follow this PR so you have an answer about it. I have a question. How Studio users upload csv files today if this is not working?

DonatoBD commented 1 year ago

Hi @santiagosuarezedunex, currently users can upload the files because we install that version of the package manually from strain when building the image

santiagosuarezedunext commented 1 year ago

This issue is part of maintenance of our product, we have o fix this bug. I am going to move it to in progress and you can follow up the progress here

dcoa commented 1 year ago

Understanding that super-csv is already updated in olive and the upstream edx-platform, we could close this issue. https://github.com/eduNEXT/edunext-platform/blob/ednx-release/olmo.master/requirements/edx/base.txt#L1092

Add a screenshot for olmo cluster testing:

image

Thank @DonatoBD for your explanation.

C.C @MaferMazu