search

efemkay / obsidian-modular-css-layout

CSS Layout hack for Obsidian.md
https://efemkay.github.io/obsidian-modular-css-layout/
GNU General Public License v3.0
918 stars 74 forks source link

`wide-page` very not-wide in Obsidian 1.4.5 #51

Closed nwpappas closed 11 months ago

nwpappas commented 1 year ago

Downloading latest version of MCL (zip says 0.9.5, source calls out 0.9.4) I added a wide-page to the cssclasses in Obsidian 1.4.5 and see the following not-so-wide-pade in edit mode:

Screenshot 2023-08-31 at 3 28 37 PM

The page is full width in view mode.

I have several snippets copied over from Minimal (I use the AnuPpuccin theme). I removed them all, keeping only MCL, but got the same result.

wide-dataview works with no other CSS:

Screenshot 2023-08-31 at 4 01 26 PM

But collapses (in edit mode) when I add the Minimal CSS styles that provide for the cards* classes:

Screenshot 2023-08-31 at 4 02 11 PM

Works fine in view mode.

Screenshot 2023-08-31 at 4 03 02 PM

albertoloscerritos commented 1 year ago

Indeed. the wide snippet has a lot of bugs in the current version of obsidian. In my case it even affected notes that didn't even used the snippet (making them narrower for some reason) when toggling between notes.

efemkay commented 1 year ago

@nwpappas if u can list the other snippets you used would help me out. Cannot repro the issues you mentioned

@albertoloscerritos yeah the wide blocks (wide dataview, wide table) need to be reworked due to many changes in obsidian structure. I'm working on revamping the wide views snippet, but I will say that making wide blocks work in edit mode has become a bit more challenging (due to line numbering gutter). I'll tag this comment when I have a new release on it

albertoloscerritos commented 1 year ago

Thanks for keeping us up to date :)

nwpappas commented 1 year ago

The example I posted did not have any additional snippets. The image posted is with the AnuPpuccin theme loaded, but the same issue appears for me when using the default theme.

I do also have several snippets that I commonly used that come from the Minimal theme. I've trimmed these snippets from Minimal's main file and put them into individual files that I can better manage manually. The 2nd image in my posts does not have any of these extra snippets loaded (only MCL snippets loaded), the 3rd image has the snippets from Minimal loaded.

efemkay commented 11 months ago

hey @nwpappas @albertoloscerritos i've released update that's rewrite the entire wide page / wide blocks snippets. can u try and see if this also fix the issue u both have

efemkay commented 11 months ago

do reopen the issue if the problem somehow persists