Remove composer.lock - Githubissues

ekandreas / bladerunner

WordPress plugin for Laravel Blade templating DEPRECATED

http://bladerunner.elseif.se

12 stars 1 forks source link

Remove composer.lock #29

Closed vinkla closed 8 years ago

vinkla commented 8 years ago

Since this is a plugin/package we don't need to include the lock file. Also updated the ignore file.

ekandreas commented 8 years ago

I'm using Bladerunner as package and not as a distributed plugin so I really don't want to remove the lock file. The plugin is downloadable via the site. Or convince me otherwise :-)

vinkla commented 8 years ago

…I really don't want to remove the lock file.

I'm curious, why do you want to keep it? Removing the composer.lock file is actually recommend by Composer.

For packages the composer.lock file is optional since it doesn't make any difference, it just takes up space in production.
For applications they highly recommend keeping it though.

vinkla commented 8 years ago

👍