search

ekinoguz / sprout-database

Database project of a graduate class.
0 stars 0 forks source link

CliTest are failing #7

Closed diedthreetimes closed 11 years ago

diedthreetimes commented 11 years ago

It looks like the drop attribute in clitest is returning a failure code.

ekinoguz commented 11 years ago

fixed.

diedthreetimes commented 11 years ago

Was it actually failing? Or was it just the cli reporting incorrectly?

ekinoguz commented 11 years ago

no it was a bug related to change in expect() function. It was working fine during demo because I updated expect() after demo

ekinoguz commented 11 years ago

btw, we have the same bug in readline branch, how to fix it neatly?

diedthreetimes commented 11 years ago

You have a few options.

1.leave it and it will be fixed when we merge deadline into master.

  1. Merge master into readline.
  2. Merge just that commit into readline using cherry pick.

I recommend 2. On May 14, 2013 1:48 AM, "ekin oguz" notifications@github.com wrote:

btw, we have the same bug in readline branch, how to fix it neatly?

— Reply to this email directly or view it on GitHubhttps://github.com/ekinoguz/cs222-database/issues/7#issuecomment-17864002 .

ekinoguz commented 11 years ago

when should we merge readline to master?

diedthreetimes commented 11 years ago

if it is working go ahead and merge now. and then you can create another branch if you'd like for ix_cli changes.

On Wed, May 15, 2013 at 11:03 PM, ekin oguz notifications@github.comwrote:

when should we merge readline to master?

— Reply to this email directly or view it on GitHubhttps://github.com/ekinoguz/cs222-database/issues/7#issuecomment-17983566 .

ekinoguz commented 11 years ago

I think we added everything for readline and it is working fine. We can close this branch. I will create ix_cli for ix changes