search

ekzhu / SetSimilaritySearch

All-pair set similarity search on millions of sets in Python and on a laptop
Apache License 2.0
588 stars 40 forks source link

What does it mean that SearchIndex cannot be updated? #3

Closed innerop closed 4 years ago

innerop commented 4 years ago

Hi,

Interesting work. I'd like to evaluate it for my use case. However, I am not getting what you mean by "Search index cannot be updated." Are you saying that it cannot be updated at all (maybe blow up the database and do over?) or that it has no update method? What if I update the sets and then create the index again? That would be creating a brand new index. To me, that's a method of updating.

Please clarify.

Thanks so much,

ekzhu commented 4 years ago

Hi, yes by your definition of update the index can be updated through rebuilding from the data.

It is theoretically possible to have an "in-place" update method for the SearchIndex without rebuilding, but I haven't gotten time to implement it.

innerop commented 4 years ago

yeah, sorry I didn't understand at first. Might be worth it to add "in-place" to the Readme unless most people assume that's what is meant =)