elastic / stream

Test utility for streaming data via udp/tcp/tls/webhook/GCP Pub-Sub/Kafka.
https://container-library.elastic.co/r/observability/stream
Apache License 2.0
8 stars 13 forks source link

bump golang version #42

Closed v1v closed 2 years ago

v1v commented 2 years ago

What

Script to bump the Golang version, so this project can be enrolled to the automated auto-bump. Remove the GO_VERSION env variable in the Pipeline since it's created on the fly by reading the .go-version file

Why

Avoid manual tasks for autobump similarly done in https://github.com/elastic/stream/pull/40/files

Test

Given .ci/bump-go-release-version.sh 1.19.2 Then it produces

diff --git a/.go-version b/.go-version
index 66e2ae6..836ae4e 100644
--- a/.go-version
+++ b/.go-version
@@ -1 +1 @@
-1.19.1
+1.19.2
diff --git a/Dockerfile b/Dockerfile
index 32e8fee..621859c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.19.1 as builder
+FROM golang:1.19.2 as builder

 RUN apt-get update \
        && apt-get dist-upgrade -y \
diff --git a/go.mod b/go.mod
index becc766..4479731 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
 module github.com/elastic/stream

-go 1.18
+go 1.19

 require (
    cloud.google.com/go/pubsub v1.25.1
elasticmachine commented 2 years ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2022-09-20T08:30:18.695+0000 * Duration: 5 min 17 sec #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 19 | | Skipped | 0 | | Total | 19 |

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with: - `/test` : Re-trigger the build.

v1v commented 2 years ago

In general the go.mod version does not necessarily need to be bumped

@andrewkroh , there was some discussions in Beats regarding that, and was requested to be bumped too, I took the lead to apply the same pattern, do you want me to remove it?

andrewkroh commented 2 years ago

do you want me to remove it?

No. Without any downstream consumers it doesn't matter and just unlocks the new features here.