elastic / stream

Test utility for streaming data via udp/tcp/tls/webhook/GCP Pub-Sub/Kafka.
https://container-library.elastic.co/r/observability/stream
Apache License 2.0
8 stars 13 forks source link

Adding Azure Blob Storage output support #47

Closed P1llus closed 1 year ago

P1llus commented 1 year ago

This PR adds support for Azure Blob Storage output, for adding system tests on integrations.

elasticmachine commented 1 year ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2023-01-17T11:05:58.191+0000 * Duration: 5 min 27 sec #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 20 | | Skipped | 0 | | Total | 20 |

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with: - `/test` : Re-trigger the build.

andrewkroh commented 1 year ago

@ShourieG Can you please review this since you are familiar with the Azure SDK.

ShourieG commented 1 year ago

@P1llus one question, do you feel it's worth while to test output for all 3 types of blobs ? Block, append & page types? Currently we are only checking for block blobs I think.

ShourieG commented 1 year ago

@P1llus Approving the PR for now, but we can enhance it later with support for other types of blobs.

P1llus commented 1 year ago

@P1llus one question, do you feel it's worth while to test output for all 3 types of blobs ? Block, append & page types? Currently we are only checking for block blobs I think.

I think we could most likely add more support later for sure, I will leave a note for it, however we would need to merge this at some point to get the integration package up