Closed EmptyInfinity closed 2 years ago
Platform team requirements:
- [x] 1. Nightly tests in CI.
- [x] 2. Disable dev dependencies check during audit.
- [x] 3. Version should adhere to semver rules. Breaking change - new major version.
- [x] 4. All tests from
object-storage-client
must be present here. Especially which cover some edge cases (like passing the same stream on retry). (Passing same stream could be covered only with positive test)- [x] 5. Exponential back-off like in
object-storage-client
. (Because of having ability to config "delay on retry" was implemented logic like this)- [ ] 6. All errors should be handled like in latest
object-storage-client
. Now they don't. E.g. I don't see Client error handler. (Error handling were left as it is, you may familiar with handling approach in integration-tests)
Now related to how our services are using the lib
ttl
. ttl
can have -1
value.Can you provide an example on how to override Content-Type
for update
?
Can you provide an example on how to override
Content-Type
forupdate
?
there is no way to pass custom contentType, because it's calculated automatically And here is integration tests examples
Platform team requirements:
object-storage-client
must be present here. Especially which cover some edge cases (like passing the same stream on retry).object-storage-client
.object-storage-client
. Now they don't. E.g. I don't see Client error handler.Now related to how our services are using the lib (I didn't check you PR in details and not sure you saved these features, most likely you did):
ttl
.ttl
can have-1
value.