search

electro-smith / libDaisy

Hardware Library for the Daisy Audio Platform
https://www.electro-smith.com/daisy
MIT License
312 stars 131 forks source link

MIDI - Specific SysEx can crash MidiHandler #501

Open stephenhensley opened 2 years ago

stephenhensley commented 2 years ago

Seems like it's possible to trip up the MidiHandler with certain SysEx data

Reported on slack:

So I've just found that the following midi message will freeze the libdaisy midi handler but no idea why. SysEx Universal Real Time 3 bytes F0 7F 7F F7 kills the midi input and yet SysEx Universal Real Time 6 bytes F0 7F 7F 06 01 F7 is fine. The first message is coming out of a RK006 midi filter box, its probably not meant to be but I wanted to make sure my module was bullet proof enough to not be tripped up by it.

makingsoundmachines commented 2 years ago

Would the first Sysex look to the parser as having no content? So be parsed as Start - End - End - End but the parser expect an actual value? The second message has 06 and 01 as values that could potentially be valid.