search

electro-smith / libDaisy

Hardware Library for the Daisy Audio Platform
https://www.electro-smith.com/daisy
MIT License
331 stars 143 forks source link

Add the SpiHandle:Config struct to SSD130x4WireTransport:Config #512

Closed recursinging closed 2 years ago

recursinging commented 2 years ago

This is a fix for issue #506. It seems a number of people have been running into this, and it was an oversight on my part, so I fixed it.

@stephenhensley - I added constructors to the Config structs that invoke Defaults() as you mention in the issue description. This should be fully backward compatible, but I don't have time to test against an SPI transport OLED. Perhaps you could quickly verify this against a Daisy Patch? Otherwise it's little more than a little code shuffling, and should not introduce any breaking changes.

Cheers, Sam

stephenhensley commented 2 years ago

@recursinging Thanks, Sam!

This looks great, I saw some of the forum activity you're talking about, and was hoping we'd be able to carve out some time this month to get this in there.

Thanks for making it happen!

Looks good to me. We'll do a quick check that everything still works with the existing Daisy Patch code, and get it merged.

stephenhensley commented 2 years ago

Looks good, and tested well here on various DaisyExamples examples.

Thanks again for the PR!