electro-smith / libDaisy

Hardware Library for the Daisy Audio Platform
https://www.electro-smith.com/daisy
MIT License
312 stars 131 forks source link

Midi Junk Status byte bugfix #515

Closed beserge closed 2 years ago

beserge commented 2 years ago

Previously, if we received a status byte when we were expecting data, we would throw it away and wait for the next message. However, in this case we should go back to the beginning of the parser and actually handle that status byte. I wrote a test that checks for this behavior. It's worth noting we did fail the test before the change!

github-actions[bot] commented 2 years ago

Unit Test Results

    1 files  ±0    16 suites  ±0   0s :stopwatch: ±0s 149 tests +2  149 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0 

Results for commit f33915c4. ± Comparison against base commit 44151454.

:recycle: This comment has been updated with latest results.