search

electro-smith / libDaisy

Hardware Library for the Daisy Audio Platform
https://www.electro-smith.com/daisy
MIT License
331 stars 141 forks source link

Fix deprecated pin API for Seed2DFM #544

Closed CorvusPrudens closed 1 year ago

CorvusPrudens commented 1 year ago

Pins 31 and 32 (Seed 2 DFM exclusive) are now available using the deprecated GetPin method. Additionally, the bounds check for the GetPin method has been tied to the length of the pin array, meaning out of bounds accesses are no longer possible.

The functionality was verified with LED objects assigned to pin 31 and 32.

github-actions[bot] commented 1 year ago

Unit Test Results

150 tests  ±0   150 :heavy_check_mark: ±0   0s :stopwatch: ±0s   16 suites ±0       0 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit 480b2273. ± Comparison against base commit e8f7e73a.