search

electro-smith / libDaisy

Hardware Library for the Daisy Audio Platform
https://www.electro-smith.com/daisy
MIT License
312 stars 131 forks source link

Allow user to override C_INCLUDES env var in makefile #586

Closed nullobject closed 11 months ago

nullobject commented 11 months ago

This change allows a user to modify the C_INCLUDES environment variable in their project makefile.

This is similar to the way the libDaisy makefile allows users to override C_SOURCES, etc.

stephenhensley commented 11 months ago

Hi @nullobject thanks for the contribution!

I believe the functionality you're attempting to add is already present in the core/Makefile -- this is the file that is imported from the user's project Makefile.

If you have a particular use-case for adding to the C_INCLUDES of libDaisy itself prior to compilation, we can discuss that further. However, it looks like might have just missed that your requested functionality already works.

nullobject commented 11 months ago

Thanks @stephenhensley, you are right. Sorry for the false alarm.

I was looking in libDaisy/Makefile, not libDaisy/core/Makefile.