electro-smith / libDaisy

Hardware Library for the Daisy Audio Platform
https://www.electro-smith.com/daisy
MIT License
312 stars 131 forks source link

Remove WM8731 TODO comment #623

Open jacobvosmaer opened 2 months ago

jacobvosmaer commented 2 months ago

I was reading the WM8731 audio codec setup code and I got confused by a comment which suggested Daisy always uses the codec with a 48kHz sample rate. After several hours of reading data sheets I figured out what is going on here: the WM8731 has built-in sample rate conversion and the nominal "48kHz" setting disables the built-in conversion.

This commit updates the comment to explain what we are actually doing here.

beserge commented 1 month ago

Looks good, nice catch!