search

elementary / capnet-assist

Captive Portal Assistant
GNU General Public License v3.0
59 stars 9 forks source link

Allow Launching from Indicator #66

Closed danirabbit closed 3 years ago

danirabbit commented 3 years ago

Fixes #3 Fixes #39

Remove the NM dispatch script, because the panel is supposed to launch capnet.

We don't need to do a connectivity check or have the force flag because there are only two cases where Capnet would be launched:

  1. We already detected a portal in the network indicator
  2. The user is manually launching capnet from Terminal, in which case it doesn't make sense to bail even if we're connected
cassidyjames commented 3 years ago

Is it possible we had the check for captive portal here as well because NM could incorrectly detect a captive network, but then by the time we were launching capnet-assist it had resolved to not be captive? I think I'm fine to merge this once I test it a bit, but it's probably worth testing this for a while in a variety of network conditions before releasing to make sure we don't suddenly get a lot more false positives.

danirabbit commented 3 years ago

Yeah I think probably the real solution to that would be to add a network monitor and connect to changes in the network state (basically exactly what we do in the indicator). That would fix #5 and or #4