elmerfds / rebuild-dndc

Re-create containers that use another container's network stack (i.e. routing container traffic through a VPN container)
GNU General Public License v3.0
22 stars 9 forks source link

Support for custom networks #63

Closed Lanjelin closed 1 year ago

Lanjelin commented 1 year ago

Did I forget to actually make the PR?

For https://github.com/elmerfdz/rebuild-dndc/issues/61

Ran in to the same issues as mentioned, as I rely heavily on custom networks in my setup. Containers communicate by container names instead of through ports opened on host, routing most traffic through reverse proxy.

Checks value of environment variable custom_network, if length is zero or value is false, it runs the usual docker inspect $mastercontname --format="{{ .NetworkSettings.EndpointID }}", else it runs docker inspect $mastercontname --format="{{ .NetworkSettings.Networks.${custom_network}.EndpointID }}"

I guess the unraid template should be updated accordingly as well.

elmerfds commented 1 year ago

Thanks for taking the time to explain and this PR.