search

emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
273 stars 16 forks source link

Option to easily scroll horizontally #17

Closed nixmaniack closed 8 years ago

nixmaniack commented 8 years ago

If you have vertical split with magit and the changes you see don't fit in the window(commit window alongside changes) it becomes difficult to scroll horizontally without vim like bindings. We have to use arrow keys to scroll.

Any options/suggestions?

justbur commented 8 years ago

Any idea what the preferred way to do this in magit is? On Thu, Feb 11, 2016 at 5:39 AM Muneeb Shaikh notifications@github.com wrote:

If you have vertical split with magit and the changes you see don't fit in the window(commit window alongside changes) it becomes difficult to scroll horizontally without vim like bindings. We have to use arrow keys to scroll.

Any options/suggestions?

— Reply to this email directly or view it on GitHub https://github.com/justbur/evil-magit/issues/17.

nixmaniack commented 8 years ago

I don't know of magit way per se, but in emacs since keybindings C-[fbea] are available it's easy to navigate around. You can use C-x [<>] to scoll left/right.

justbur commented 8 years ago

C-f for me is the gitflow popup.

I added C-t to toggle text-mode a little while ago, which is one option.

I guess enough people have asked for this that it's time to explore what it would require. Moving h for help to H looks like it would work. There are two log popups on l and L and it looks reasonable to move them "up" to L and C-l. Would that be adequate?

justbur commented 8 years ago

Done in https://github.com/justbur/evil-magit/commit/99019a5c1529045b8e88dfe50ae8ccf3ed905362

Set evil-magit-want-horizontal-movement to t. I think I hit all of the points where something should change, but please let me know if you notice an inconsistency.

nixmaniack commented 8 years ago

Moving h for help to H looks like it would work. There are two log popups on l and L and it looks reasonable to move them "up" to L and C-l. Would that be adequate?

Sure this is very much consistent with vim.

nixmaniack commented 8 years ago

Oh wow! That was quick. I will try and and report any issues if found. Thanks!

nixmaniack commented 8 years ago

Works perfect. Thank you.