Add binding for magit-reset-popup

[fbergroth]

It was recently introduced.

[justbur]

Any suggestions for where to put it?

[fbergroth]

X feels natural, but I don't have a good suggestion that doesn't collide :confused:

[justbur]

X is taken already k and K were moved to x and X. Any other suggestions would be welcome.

[fbergroth]

For symmetry with C-r (magit-reset), I guess it makes sense to bind it to C-R or M-r.

Magit has magit-reset on x and magit-reset-popup on X.

[justbur]

Yes that would be the natural thing to do but I feel there must be a better way.

[justbur]

Here's some possibilities

1. C-R because it follows the other rules. Bad because it's three keys and not very vim-like
2. ' for reset and " for the popup. Not mnemonic at all, but on the home row and not taken really.
3. , for reset and < for the popup. I like the back arrow for reset, but that's about it.

Do you like any of those?

[justbur]

I never liked o and O for revert, so maybe those are better for reset and we can put revert somewhere else. The mnemonic was "old", and maybe that's better for reset as in go back to an old state.

[andyleejordan]

Unfortunately the choice of - is also already taken, by magit-diff-less-context.

[justbur]

Crap, you're right. I forgot about that one, because I never use it.

It seems that = would work for diff-less-context. Would that be adequate?

[andyleejordan]

Seems fine to me :)

[justbur]

@andschwa Should be fixed now. Sorry for the oversight

[andyleejordan]

No problem :smile: