search

emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
273 stars 16 forks source link

magit-gh-pulls help text needs to be overriden #24

Closed robbyoconnor closed 8 years ago

robbyoconnor commented 8 years ago

There needs to be a way to override the helpdesk displayed in the magit-status buffer. Since # g is overriden, users will get confused when it doesn't work. My emacs lisp chops aren't great but will take a stab at this.

justbur commented 8 years ago

That text looks hard to change. I just removed the change in key binding

robbyoconnor commented 8 years ago

Will this cause problems with evil?

justbur commented 8 years ago

No it was just for consistency On Thu, Jul 14, 2016 at 4:45 PM robbyoconnor notifications@github.com wrote:

Will this cause problems with evil?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/justbur/evil-magit/issues/24#issuecomment-232786866, or mute the thread https://github.com/notifications/unsubscribe/ACGyfgneV9UlyV0ulkaOTiYlEaobzNJMks5qVp_PgaJpZM4JMpHp .

robbyoconnor commented 8 years ago

Okay thanks @justbur =)

d12frosted commented 8 years ago

Yesterday I made a PR for this https://github.com/sigma/magit-gh-pulls/pull/95. Was waiting for this to be accepted and then was gonna PR here 😸

But to be honest, I like # g much more 😸 Though it's funny to listen to me, cause I don't do evil myself! 💃

Update So when that PR is resolved you can bring that key binding back to maintain consistency.