search

emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
273 stars 16 forks source link

evil-magit breaks evil-want-C-u-scroll #27

Closed zhenchaoli closed 7 years ago

zhenchaoli commented 7 years ago

I set evil-want-C-u-scroll to true so that I can scroll up exactly like in vim, installing evil-magit breaks it and I couldn't scroll back with C-u any more.

evil version: 1.2.12 evil-magit version: 20161130.847

justbur commented 7 years ago

I need more information. Are you saying it breaks it everywhere? In all magit buffers? In particular buffers?

NicholasTD07 commented 7 years ago

@justbur Thanks for this package. It works really nicely. Apart from this C-u issue.

I also have the same problem and I found out it's because of the evil-magit package. If I remove the package, without any other change to my configurations, C-u works.

The C-u does not work in evil-normal or evil-visual mode nor does it work in magit buffers.

Let me know how can I help.

Emacs: 25.2.1 evil: 20170712.2350 evil-magit: 20170613.510

justbur commented 7 years ago

It still doesn't make sense to me. I'll need a config that I can use from emacs -Q to reproduce this.

NicholasTD07 commented 7 years ago

@justbur Here's my emacs configuration. https://github.com/NicholasTD07/dotfiles/tree/master/.emacs.d

To reproduce the issue

Clone my dotfile repo and checkout at this commit https://github.com/NicholasTD07/dotfiles/commit/c4ac9bbeab14146874be95e1664d2fce6ef101ae and load the init.el file. The evil-magit configuration is in that commit. I removed it in the one after it.

It should help you reproduce the issue.

Let me know if I can help you in anyway :)

justbur commented 7 years ago

evil-want-C-u-scroll needs to be set before evil is loaded. evil-magit loads evil, and it appears you are loading evil-magit before evil which will cause the problem. This isn't an evil-magit bug.

NicholasTD07 commented 7 years ago

@justbur Thanks. After adjusting my configs, C-u works!

Sorry for the falsely bug reporting. Emacs is still quite new to me and there are so many things I am still trying to understand.

Thanks.

justbur commented 7 years ago

No problem

zhenchaoli commented 7 years ago

yeah, works for me as well now. Thanks!