search

emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
273 stars 16 forks source link

Region Staging doesn't work #4

Closed CestDiego closed 8 years ago

CestDiego commented 8 years ago

To reproduce: go into visual selection either with v or V in the magit-status buffer, inside a chunk... then try to move either up or down with j or k...the selection will dissapear.

justbur commented 8 years ago

It's working for me. I wonder if you just can't see the region because of your theme.

CestDiego commented 8 years ago

No, I try to select and then stage and it stages the whole chunk instead of some region of it.

justbur commented 8 years ago

Yes, I understand. It works for me. I can stage part of a chunk. I'll need more information to diagnose this.

What does C-h k v say in a chunk? What about C-h k j? Should be set-mark-command and evil-next-visual-line respectively.

CestDiego commented 8 years ago

I figured this out. It's got to do with me having evil-escape-sequence at jk...everything is bound to what it needs but it seems evil-escape is doing some stuff that blocks j or k...

CestDiego commented 8 years ago

Must be related to https://github.com/syl20bnr/evil-escape/issues/52

justbur commented 8 years ago

Ah ok. Maybe file an issue with evil-escape. I haven't used evil-escape in a while so I didn't test against it. On Fri, Nov 6, 2015 at 6:39 PM Diego Berrocal notifications@github.com wrote:

I figured this out. It's got to do with me having evil-escape-sequence at jk...everything is bound to what it needs but it seems evil-escape is doing some stuff that blocks j or k...

— Reply to this email directly or view it on GitHub https://github.com/justbur/evil-magit/issues/4#issuecomment-154577968.

justbur commented 8 years ago

Noted in the readme so I'm going to close this for now. Please reopen if something changes

CestDiego commented 8 years ago

thanks :)