Naming changes in project.

emacs-evil / evil-magit

Black magic or evil keys for magit

https://github.com/justbur/evil-magit

GNU General Public License v3.0

272 stars 16 forks source link

Closed MichaelStergianis closed 6 years ago

MichaelStergianis commented 6 years ago

magit-blame-mode-map was changed to blame-read-only-mode-map magit-blame-read-only-mode was added magit-error-section-map was added

mriehl commented 6 years ago

Thanks for this, I was getting initialization errors related to the magit-blame-mode-map and this fixed it!

kommen commented 6 years ago

I can confirm this fixes #43

FieryCod commented 6 years ago

It's crucial to merge this.

Paryz commented 6 years ago

guys please 😄 without magit I feel handless 😢

justbur commented 6 years ago

Thanks!

stradicat commented 6 years ago

I keep getting the exact same error 2 days after it was allegedly fixed. Removed packages, let Spacemacs install them again, problem persists.

justbur commented 6 years ago

@dennismayr It works fine for me on evil-magit version 20180410.804 from melpa

farynaio commented 5 years ago

I had to add (defvar magit-blame-read-only-mode-map (make-sparse-keymap)) before (require 'evil-magit) to make it work.

magit-20180406.1110 evil-magit-20180702.1553

justbur commented 5 years ago

@adamfaryna That shouldn't be necessary. It seems you have an old version of magit, but I don't know why that would be a problem.