emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
272 stars 16 forks source link

Support for GPG signing #66

Closed lucianonooijen closed 5 years ago

lucianonooijen commented 5 years ago

It seems like currently there is no built in support for GPG signing commits in the commit screen (SPC - g - s, S - y, c).

This would be a great feature to add

justbur commented 5 years ago

You’re proposing keybindings for the commit buffer? What are the corresponding bindings in magic?

lucianonooijen commented 5 years ago

I'm not familiar with Magit bindings as I'm new to Emacs/Spacemacs, although I found this reference to it in the source code. Due to my very limited skills with (Emacs-)Lips, I'm not sure what the functionality added by the reference on line 115 is.

justbur commented 5 years ago

Magit handles this in the commit popup, not in the commit buffer. See for example https://emacs.stackexchange.com/questions/18514/how-to-automatically-sign-commits-with-magit/18524