emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
273 stars 16 forks source link

In vanilla Magit I can use C-u s to do a "git add -N", can I do this with evil-magit? #67

Closed fnune closed 5 years ago

fnune commented 5 years ago

I want to use git add -N with Magit.

       -N, --intent-to-add
           Record only the fact that the path will be added later.
           An entry for the path is placed in the index with no
           content. This is useful for, among other things, showing
           the unstaged content of such files with git diff and
           committing them with git commit -a.

This behavior is supported by vanilla Magit by using C-u s, it was implemented in this PR.

How can I do this with evil-magit?

P.S. Thank you for this package :)

justbur commented 5 years ago

I'm not sure how this would be handled in evil-magit. Do you have a key binding in mind?

fnune commented 5 years ago

I was thinking it could be the default s action when adding new files. A subsequent s could actually stage the changes?

justbur commented 5 years ago

It’s not a bad suggestion but I’d rather stay close to the way Magit works. I think that’s a suggestion that could be made on the Magit side.

fnune commented 5 years ago

What about just n? for git add -N or i<n>tent?

justbur commented 5 years ago

That’s reserved for searching.

On Wed, Jun 19, 2019 at 6:04 AM Fausto NA notifications@github.com wrote:

What about just n? for git add -N or itent?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/emacs-evil/evil-magit/issues/67?email_source=notifications&email_token=AAQ3E7U3JLTJHSQCHZJRNSDP3IADBA5CNFSM4HYGDKVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYBLXNY#issuecomment-503495607, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ3E7W7OJ33K7TL2VKXH73P3IADBANCNFSM4HYGDKVA .

fnune commented 5 years ago

How about capital I (i) for <i>ntent? Currently I get an "ignore" dialog but that also works with lowercase i. We could:

justbur commented 5 years ago

ok, worth a try. I added it in 91e5dfb

fnune commented 5 years ago

Cool! Thanks!

fnune commented 5 years ago

Working great on the new release btw.