search

emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
273 stars 16 forks source link

Forge: cannot create pull request when using magit forge #74

Open rezmuh opened 4 years ago

rezmuh commented 4 years ago

Hi, i'm pretty new to Emacs. I am using doom-emacs (with magit, evil-magit and forge). I saw that forge was supported in evil-magit.

I tried to use forge's create pull request feature. I saw a new buffer opened up and I save the document with :wq. The pull request message file is saved in .git/magit/posts/new-pullreq. However the pull request isn't sent to GitHub.

I raised this issue in Magit forge repo: https://github.com/magit/forge/issues/208 but it looks like the issue was more related to evil-magit (since if I do C-c C-c in new pull-request buffer, the PR is created).

I have no issue with creating new commits though. When i commit, I can still use :wq to save and quit the buffer to create new commits.

Is this a known bug, or did I miss something?

justbur commented 4 years ago

It's not a bug so much as it's a keybinding that hasn't been created yet. I replied in the issue you created on the forge issue.