emacs-evil / evil-magit

Black magic or evil keys for magit
https://github.com/justbur/evil-magit
GNU General Public License v3.0
272 stars 16 forks source link

Evil-magit now part of evil-collection #87

Open countvajhula opened 3 years ago

countvajhula commented 3 years ago

Just a PSA for anyone encountering startup issues with evil-magit. After updating my Emacs packages, I was running into issues resembling:

magit-branch is not a transient command k not found in magit-branch magit-file-mode-map is void

... when trying various permutations of magit and evil-magit versions. When I finally disabled evil-magit I found to my surprise that the evil bindings in magit were still working! Turns out this is because evil-magit has been merged into evil-collection, as indicated in the README.

terzievk commented 3 years ago

Same here. Having both evil-magit and evil-collection in my config, I get k not found in magit branch only the first time I call magit-status. Each successive magit-status call works as expected. The whole error message I get in *Messages* is:

transient-get-suffix: k not found in magit-branch

Removing evil-magit from my config fixes the issue. I am writing this comment because googling for "transient-get-suffix: k not found in magit-branch" did not suggest this issue and writing this comment might help somebody with the search results.

mohkale commented 3 years ago

I don't have evil-collection but I still get the evil-magit is obsolete. This package is now part of evil-collection. Having both installed will cause unintended behavior. message. Could you disable the message when evil-collection isn't installed.

justbur commented 3 years ago

It is still obsolete. I submitted a pr to remove it from melpa, and I will ask to archive the repo (I can't seem to do it myself for some reason). You're welcome to fork it if you like.

@TheBB maybe you have to do the archiving?

gzmask commented 2 years ago

you will also need magit itself if you don't use evil-magic and only having evil-collection.