search

emacs-helm / helm-ls-git

An alternative to Magit and Vc using Helm to manage git projects
120 stars 19 forks source link

helm-marked-files-in-dired fails when helm-ff-default-directory is nil #49

Open cmccloud opened 6 years ago

cmccloud commented 6 years ago

Attempting to use the helm-marked-files-in-dired action fails when called from helm-source-ls-git, as the value of helm-ff-default-directory is nil. Advising helm-ls-git-ls to let-bind the value of helm-ff-default-directory to (helm-ls-git-root-dir) works as a temporary fix.

To reproduce: Navigate to a valid project and call helm-ls-git-ls Navigate to the helm-source-ls-git source named "Git files" Mark 0 or more files From select action menu, select "Marked files in dired"

thierryvolpiatto commented 6 years ago

Christopher McCloud notifications@github.com writes:

Attempting to use the helm-marked-files-in-dired action fails when called from helm-source-ls-git, as the value of helm-ff-default-directory is nil. Advising helm-ls-git-ls to let-bind the value of helm-ff-default-directory to (helm-ls-git-root-dir) works as a temporary fix.

Thanks, I let-bind it to default-directory, should work now.

-- Thierry