search

emanuelen5 / kitchen-timer

0 stars 0 forks source link

Reuse some code for the rotary-encoder #4

Closed emanuelen5 closed 6 months ago

emanuelen5 commented 6 months ago

I didn't mean for us to merge this PR before we had fixed so it actually compiled. I should have put the PR in draft mode / commented on it to be more clear.

This PR unfortunately makes the project only build for the rotary-encoder and state_machine sketches... (see the build status and the ❌ symbol above: https://github.com/emanuelen5/kitchen-timer/actions/runs/8725836402/job/23939742387)

========================== [FAILED] Took 2.64 seconds ==========================

Environment     Status    Duration
--------------  --------  ------------
timer           FAILED    00:00:15.642
sleep           FAILED    00:00:00.823
rotary-encoder  SUCCESS   00:00:00.836
arduinoisp      FAILED    00:00:00.924
state_machine   SUCCESS   00:00:00.861
buzzer          FAILED    00:00:02.640
==================== 4 failed, 2 succeeded in 00:00:21.726 ====================

But don't worry, we can fix it up :)

nperozzi commented 6 months ago

I understand. I merged cause the PR was there for me to review. I may have gotten ahead of myself haha 😅.