Application library

[nperozzi]

This is my second shot to the Application library. I don´t think it is looking great but I think I need some feedback to see what is wrong and how to approach it.

How is it structured?

• init_application: initializes all state machines and sets the first one as active.
• step_application:
  • increments the current_timer in all RUNNING state machines every SECOND_TICK. If after the increment, the state is RINGING, then it makes the state machine "active"
  • Handles the DOUBLE_PRESS event to change the active timer to the next timer. This is done here cause one can change to the next timer in any state. (maybe I should have done the same with the LONG_PRESS since it always resets the timer, no matter what state).
  • Runs the step_state function for the active state machine. This is done for all events except for SECOND_TICK (since SECOND_TICK is handled before) unless the active state machine is in RUNNING state (since SECOND_TICK event, triggers the printf to see the current_time).

I hope this is somewhat understandable. I am looking forward to hearing your comments. 😄

[emanuelen5]

^ I rebased the changes to fix the merge conflict, and make the diff easier to review

[nperozzi]

I had to move the led_counter() functions from the state machine layer to the application layer because the LEDs refresh every time any state machine refreshes (5 times per second). This made me think that I should remove all the debugging printf comments to the application layer. @emanuelen5, what do you think?

[nperozzi]

I still need to pass all the tests.

[emanuelen5]

I still need to pass all the tests.

I can see that the tests fail to compile. It looks like this is due to the library resolver pulling in AVR libraries when compiling the library lib/platform-independent.

To be honest, I've cheated a bit - the state machine isn't truly platform independent since it's using the UART functions (which use the serial port on the AVR) and the debug LEDs (which use the GPIO on the AVR). But I've worked around this in the following way previously :) :

1. In the application.cpp file, remove these two lines

https://github.com/emanuelen5/kitchen-timer/blob/68334ff1847745c63f99f073b05905e078b049e9/lib/platform-independent/application.cpp#L2-L3

2. and then add the following declarations to the file:

https://github.com/emanuelen5/kitchen-timer/blob/07a3ae504d34a1143a7160354833772fcac7eea9/lib/platform-independent/state-machine.cpp#L5-L7

That will stop the library resolver from pulling in the AVR-files when compiling the platform-independent library.