Implemented interrupt queuing system

emanuelen5 / kitchen-timer

0 stars 0 forks source link

Implemented interrupt queuing system #6

Closed nperozzi closed 4 months ago

nperozzi commented 4 months ago

I implemented the queuing system in the rotary-encoder library. 1) queuing interrupts: The ISRs debounce and add interrupts to the interruptQueue[] 2) dequeuing interrupts: The dequeuing_interrupts is called in the main loop. It checks if there are interrupts queued triggers the first one and moves the front of the queue variable. Then it processes the interrupt depending on which one it is.

nperozzi commented 4 months ago

I made the modification that we agreed on Thursday 😊:

I made a separate function to test if the queue is full
I broke out the event_queue library from the rotary-encoder library. I see that my new commits have been pushed correctly into the interrupt_queue branch and they seem to have been added to this same pull request (great! 😃). Looking forward to hearing the feedback 😄

nperozzi commented 4 months ago

I think I fixed all the comments 👏

emanuelen5 commented 4 months ago

By the way: I pushed some changes above to minimize the diff and just format the files with clang-formatter. In f97932c57bb9442d8df3ebc4e195b703fe0add7a I changed so we in fact use the event_t type when we should.

nperozzi commented 4 months ago

I can see how now the event_queue could work independently from the rest of the code.
Yes, we can do a squash (if I googled correctly, it is the rearrangement of the git history so it is more readable)
Some variables and functions could change name, yes. For example, the library is called "even_queue" but, I guess that the queue could eventually be of things other than events too.
We can bring these things up during today's meetup. 😊

Looking forward to merging this branch!